astuff / kvaser_interface

A Kvaser CAN interface ROS abstraction layer.
MIT License
83 stars 51 forks source link

Modify Log Printing #92

Closed sungchan1 closed 3 months ago

sungchan1 commented 8 months ago

After running colcon build, I encountered the following warning message and made modifications accordingly

`--- stderr: kvaser_interface
In file included from /opt/ros/humble/include/rclcpp/rclcpp/logging.hpp:24, ... .... from /home/user/work_space/project/src/kvaser_interface/include/kvaser_interface/kvaser_reader_node.hpp:24, from /home/user/work_space/project/src/kvaser_interface/src/kvaser_reader_node.cpp:21: /home/user/work_space/project/src/kvaser_interface/src/kvaser_reader_node.cpp: In constructor ‘kvaser_interface::KvaserReaderNode::KvaserReaderNode(rclcpp::NodeOptions)’: /home/user/work_space/project/src/kvaser_interface/src/kvaser_reader_node.cpp:45:35: warning: format ‘%d’ expects argument of type ‘int’, but argument 5 has type ‘uint64_t’ {aka ‘long unsigned int’} [-Wformat=] 45
RCLCPP_INFO(this->get_logger(), "Got hardware ID: %d", hardwareid); ^~~~~ ~~~~
uint64_t {aka long unsigned int}
/home/user/work_space/project/src/kvaser_interface/src/kvaser_reader_node.cpp:45:54: note: format string is defined here 45 RCLCPP_INFO(this->get_logger(), "Got hardware ID: %d", hardwareid); ~^
int
%ld

In file included from /opt/ros/humble/include/rclcpp/rclcpp/logging.hpp:24,

             from /home/user/work_space/project/src/kvaser_interface/include/kvaser_interface/kvaser_reader_node.hpp:24,
             from /home/user/work_space/project/src/kvaser_interface/src/kvaser_reader_node.cpp:21:
/home/user/work_space/project/src/kvaser_interface/src/kvaser_reader_node.cpp: In member function ‘void kvaser_interface::KvaserReaderNode::read()’: /home/user/work_space/project/src/kvaser_interface/src/kvaser_reader_node.cpp:137:29: warning: format ‘%s’ expects argument of type ‘char*’, but argument 6 has type ‘std::string’ {aka ‘std::__cxx11::basic_string’} [-Wformat=] 137 this->get_logger(), "Error reading CAN message: %d - %s", ^~~~~~~~ 138 static_cast(ret), KvaserCanUtils::returnStatusDesc(ret)); ~~~~~~~~~
std::string {aka std::__cxx11::basic_string}
/home/user/work_space/project/src/kvaser_interface/src/kvaser_reader_node.cpp:137:63: note: format string is defined here 137 this->get_logger(), "Error reading CAN message: %d - %s", ~^
char*

In file included from /opt/ros/humble/include/rclcpp/rclcpp/logging.hpp:24,

             from /home/user/work_space/project/src/kvaser_interface/include/kvaser_interface/kvaser_writer_node.hpp:24,
             from /home/user/work_space/project/src/kvaser_interface/src/kvaser_writer_node.cpp:21:
/home/user/work_space/project/src/kvaser_interface/src/kvaser_writer_node.cpp: In constructor ‘kvaser_interface::KvaserWriterNode::KvaserWriterNode(rclcpp::NodeOptions)’: /home/user/work_space/project/src/kvaser_interface/src/kvaser_writer_node.cpp:46:35: warning: format ‘%d’ expects argument of type ‘int’, but argument 5 has type ‘uint64_t’ {aka ‘long unsigned int’} [-Wformat=] 46 RCLCPP_INFO(this->get_logger(), "Got hardware ID: %d", hardwareid); ^~~~~ ~~~~
uint64_t {aka long unsigned int}
/home/user/work_space/project/src/kvaser_interface/src/kvaser_writer_node.cpp:46:54: note: format string is defined here 46 RCLCPP_INFO(this->get_logger(), "Got hardware ID: %d", hardwareid); ~^
int
%ld

Finished <<< kvaser_interface [23.9s]`