astuff / pacmod3

PACMod Board Rev 3 Driver
MIT License
24 stars 14 forks source link

ROS2: Add rear pass door rpt #120

Closed icolwell-as closed 2 years ago

icolwell-as commented 2 years ago

Add support for RearPassDoorRptMsg, the parsing code is already in place, so this is all that's needed to tell the driver to parse the message as a SystemRptInt and publish to a certain topic.

icolwell-as commented 2 years ago

@wep21, thanks for offering to test this PR, please approve if testing is successful. Thanks!

wep21 commented 2 years ago

@icolwell-as I confirmed the rear pass door function worked correctly.

ros2 topic echo /pacmod/rear_pass_door_rpt 
---
header:
  stamp:
    sec: 1646346498
    nanosec: 25628679
  frame_id: pacmod
enabled: true
override_active: false
command_output_fault: false
input_output_fault: false
output_reported_fault: false
pacmod_fault: false
vehicle_fault: false
command_timeout: false
manual_input: 0
command: 1
output: 1
---

Could you merge this PR? Also, I appreciate it if you could release the new binary from your s3 server.

icolwell-as commented 2 years ago

Thank you very much for testing @wep21 !

We will have a new release available via s3 within the next 24 hours.

icolwell-as commented 2 years ago

@wep21, Release 2002.1.0 is now available on Foxy and Galactic for both amd64 and arm64.