search

astuff / pacmod3

PACMod Board Rev 3 Driver
MIT License
25 stars 14 forks source link

Firmware version included in message or new topic #49

Open icolwell-as opened 5 years ago

icolwell-as commented 5 years ago

I think it would be very helpful to have the PACMod firmware version published to an existing topic or to some new topic. This way a recorded rosbag always has PACMod firmware version already included.

JWhitleyWork commented 5 years ago

This first requires a change to the DBC (and firmware) to transmit the version. This is underway in astuff/pacmod_dbc#10. Once that issue is implemented, I'll follow up with relevant changes to the driver.

JWhitleyWork commented 5 years ago

@icolwell-as - This is now available in the DBC and will be published by newer versions of the firmware (see https://github.com/astuff/pacmod_dbc/commit/f785a2c9171563aba956dcfe6397b305482cfdfb). Would you mind implementing it in the driver?

icolwell-as commented 5 years ago

Sounds good! I might not get to it for a while, but I'm interested to learn more about this driver in the process.