Maint/cpp 11 updates - Githubissues

astuff / pacmod3

PACMod Board Rev 3 Driver

MIT License

25 stars 14 forks source link

Maint/cpp 11 updates #57

Closed JWhitleyWork closed 5 years ago

JWhitleyWork commented 5 years ago

Designed to be merged after #56. General clean-up. Adding lots of constexpr. Reducing code duplication and unnecessary global copies of publishers and subscribers.

[x] Tested in Vehicle

JWhitleyWork commented 5 years ago

Tested in Lexus RX 450h.

JWhitleyWork commented 5 years ago

Sorry, @mlemm99 - Can you review again? I forgot to update the copyrights.

JWhitleyWork commented 5 years ago

Thanks!

jilinzhouas commented 5 years ago

Currently the code is publishing a lot of ros topics. Can we provide some mechanisms to enable/disable some ros topics in the future?

JWhitleyWork commented 5 years ago

@jilinzhouas - I agree. Please create an Enhancement issue on this repo.