search

asu-ke-web-services / search-api

Search API for documents, data, research, people, etc
MIT License
2 stars 1 forks source link

"Forward" Google Geo Coder #104

Closed ESmith92 closed 8 years ago

ESmith92 commented 8 years ago

so I read over how google set up the calls for the forward geo coding and it seems that the reverse geo coder classes could be use with a different parser and a update to the url builder to allow for address parameter rather than lat and log.

Would you like to have the two types of geo coders completely separate or should the forward geo coder only have a new parser and maybe a new url builder?

rraub commented 8 years ago

What is common between the two should be shared and what is different should be different. What I shouldn't see is two classes that are 90% the same with the exception of the word "forward" or "reverse". Does that make sense?

Two parsers could be fine, if they have the same interface then I would make them inherit or implement that interface to reduce code duplication.

ESmith92 commented 8 years ago

alright, should i have the url be one class then... the only difference is address= rather than latlng= in the url