asu-ke-web-services / search-api

Search API for documents, data, research, people, etc
MIT License
2 stars 1 forks source link

Eric s geo coder #105

Closed ESmith92 closed 8 years ago

ESmith92 commented 8 years ago

update url builder -rename google_builder() to reverse_google_builder() -add forward_google_builder() -add address variable -add set_address() -update function name in test and google-revrse-geocoder class

update google-reverse-geocoder -rename get_url() to get_reverse_url() -add get_forward_url() -move service call and json decode to function get_data() -update get_locations() to use get_data() -add get_coordinates() to get coords from a "address" -update spec test to use get_reverse_url() -update implementation to force new functions()

create parser for the forward geo coding -add class to loop through the json from google forward geo coding -loops through results and selects the coordinates -checks if coordinate is already in the array -returns an array of GeoCoordinates -update google-reverse-geocoder to use the forward parser for the forward geo coding

create test for the forward geo coding -create unit testing to check that forward geo parser is initalizable -create spec tests for the forward geo coding -update googleReverseGeocoderSpec to have test for the forward geo coding -add test to check url builder returned url -add test to run through the process of forward geo coding -create spec tests for the forward geo coding parser -create integration testing with google's forward geo coding service

coveralls commented 8 years ago

Coverage Status

Changes Unknown when pulling 56e32561becc5831c2feb27b5ba5741714de5e76 on EricS-GeoCoder into \ on develop**.

rraub commented 8 years ago

Sorry it took me so long to look at this!

ESmith92 commented 8 years ago

It broke while composer was updating and I don't know how to rerun the test without just making a new pull request

rraub commented 8 years ago

I restarted the tests for you, thanks for making the corrections!