search

asu-ke-web-services / search-api

Search API for documents, data, research, people, etc
MIT License
2 stars 1 forks source link

snake_case #68

Closed kenprice closed 8 years ago

kenprice commented 8 years ago

Are we using snake_case??

Latest Travis build for my ken-query-builder branch is littered with these types of errors in the logs:

 18 | ERROR   | [ ] Variable "keywordStrings" is not in valid

    |         |     snake_case format

 18 | ERROR   | [ ] Variable "keywordStrings" is not in valid

    |         |     snake_case format

 21 | ERROR   | [ ] Variable "keywordStrings" is not in valid

    |         |     snake_case format
idmontie commented 8 years ago

The coding standards repo that we use was updated and now enforces the use of snake case. We are debating whether to disable it or not.

rraub commented 8 years ago

It can disabled with: <exclude name="WordPress.NamingConventions.ValidVariableName"/>

But it might be worth keeping on if there aren't too many offenses to fix.

rraub commented 8 years ago

fixing these new coding standards should get in the way of a new features. Adopting a new standard thats requires big changes can be its own issue to be solved.

kenprice commented 8 years ago

Addressed in this PR; closing.