Closed kenprice closed 8 years ago
Completed @jkarner 's jillian-feature-testworkflow branch.
jillian-feature-testworkflow
Follows this diagram for the most part, sans error handling. But we'd like to make a PR so we can move on to integration testing.
PR should:
handle_request
SearchEngine
SearchResult
SearchRequest
tagger_service
get_locations
SearchTerm
SolrSearch
Providers\SolrSearch
Services\Search
query
SearchResultItem[]
@rraub Failing due to decreased test coverage; is the current coverage acceptable?
Completed @jkarner 's
jillian-feature-testworkflow
branch.Follows this diagram for the most part, sans error handling. But we'd like to make a PR so we can move on to integration testing.
PR should:
handle_request
forSearchEngine
return aSearchResult
given aSearchRequest
.tagger_service
if document is providedget_locations
if coordinates are providedSearchTerm
, and add any additional user-provided search terms to the array.SearchTerm
to dispatch a query toSolrSearch
.Providers\SolrSearch
andServices\Search
to havequery
returnSearchResultItem[]
instead ofSearchResult
.SolrSearch
(bug fix).SearchEngine
.