search

asu-ke-web-services / search-api

Search API for documents, data, research, people, etc
MIT License
2 stars 1 forks source link

Make NerTagger Constructor, which is injectable #85

Closed rraub closed 8 years ago

rraub commented 8 years ago

https://github.com/gios-asu/search-api/blob/develop/src/providers/ner-tagger.php#L31-L41

iajohns1 commented 8 years ago

https://github.com/gios-asu/search-api/commit/39d1b1c93a5456d0322e78bb257a417ac0929f04

Is this what you wanted? If so, you I create a pull request for this now or wait until I add error handling to the tagger?

rraub commented 8 years ago

That will work, after the construction of the NerTagger object we can mock the $tagger class variable for testing.