search

asu-ke-web-services / search-api

Search API for documents, data, research, people, etc
MIT License
2 stars 1 forks source link

Eric http get #88

Closed ESmith92 closed 8 years ago

ESmith92 commented 8 years ago

Update http-get

-add timeout for curl calls that last longer than 2 mins.
-add check for failed curl call (returned false)
     -throws exception and returns information about the failed curl call
-add http get unit tests
        -add test to check that the http get is initalizable
        -add test to check for exception on bad curl call
               -checks that the exception message is about the curl call failure
rraub commented 8 years ago

@ESmith92 don't forget about fixing the issues in the PR

ESmith92 commented 8 years ago

@rraub what do you mean PR? Changing the seconds bar name?

rraub commented 8 years ago

PR = Pull Request

Yes the $seconds change and adding a "good" site to test with.

ESmith92 commented 8 years ago

Alright, I'll do that in a few mins.