Code review request - update_udhr_samples

asukiasov / noto

Automatically exported from code.google.com/p/noto

0 stars 0 forks source link

Code review request - update_udhr_samples #325

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago

Branch name: update_udhr_samples, see rc33f154b7961

Purpose of code changes on this branch: add tool to fetch and update text 
samples based on the UDHR data at unicode.org.

When reviewing my code changes, please focus on: everything...

After the review, I'll merge this branch into:
/master

Original issue reported on code.google.com by dougf...@google.com on 3 Apr 2015 at 1:38

GoogleCodeExporter commented 9 years ago

Original comment by dougf...@google.com on 24 Apr 2015 at 8:50

Changed title: Code review request - update_udhr_samples

GoogleCodeExporter commented 9 years ago

Roozbeh, please reevaluate this change.

rc33f154b7961 has links to the additional commits.

Original comment by dougf...@google.com on 18 May 2015 at 10:42

GoogleCodeExporter commented 9 years ago

I looked at rc33f154b7961. Makes sense in principle. I'm assuming James will be 
reviewing the actual code. If you want me to review the code in rc33f154b7961, 
please tell me and assign this issue to me.

Original comment by roozbeh@google.com on 20 May 2015 at 8:27

GoogleCodeExporter commented 9 years ago

James, can you look at this code?  Thanks.

Original comment by dougf...@google.com on 22 May 2015 at 1:20