Closed GoogleCodeExporter closed 9 years ago
changes in branch lint_whitespace, r6c1305e34a9f
I left one font unit of slop around the tests, rounding error etc. MS's
document specifies a different value (1 off) for one of these than the rounded
value I get.
Sascha's code was not using the right character for the '.' width, so the
values there were off. But for that, the new code generates the same values
his did (modulo my rounding changes). I report fewer problems since I accept
the off-by-one values.
Roozbeh, can you look the code over?
Original comment by dougf...@google.com
on 8 Apr 2015 at 11:46
Doug, can you point to the MS's document you're talking about?
Original comment by roozbeh@google.com
on 9 Apr 2015 at 2:31
Found the MS document (it's in the code). Reviewing the code now.
Original comment by roozbeh@google.com
on 9 Apr 2015 at 2:33
I just posted my comments on the code at r6c1305e34a9f.
Original comment by roozbeh@google.com
on 9 Apr 2015 at 2:57
Fixes in r68c309a4aedd.
Original comment by dougf...@google.com
on 9 Apr 2015 at 7:46
Original comment by dougf...@google.com
on 27 Apr 2015 at 10:35
Original issue reported on code.google.com by
roozbeh@google.com
on 8 Apr 2015 at 7:35Attachments: