asulaiman / pagedown

Automatically exported from code.google.com/p/pagedown
Other
2 stars 0 forks source link

Sanitizer needs a semicolon at the end #5

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. use a tool like Chirpy to package all three Markdown.*.js files together: 
Converter, Sanitizer, and Editor.
2. include the javascript file in a page

What is the expected output? What do you see instead?

I'd expect the page to behave the same way as if I included the javascript 
files individually. Instead, it has a javascript error because Sanitizer ends 
with a function call that doesn't return anything, and Editor begins with a 
parenthesis, which makes the javascript think you're calling a function that 
got returned from the Sanitizer's initialization function.

You can fix this issue by adding a semicolon at the end of the Sanitizer.js 
file, as shown in the included Hg patch file.

Original issue reported on code.google.com by Striplin...@gmail.com on 1 Sep 2011 at 11:05

Attachments:

GoogleCodeExporter commented 8 years ago
Oops yes, missed that. Thanks!

I would have applied your patch; unfortunately you changed every single line of 
the file (by converting the line ending).

http://code.google.com/p/pagedown/source/detail?r=e4b33b78d95896d282ea5632fcd83d
9cba18b71b

Original comment by b...@stackoverflow.com on 2 Sep 2011 at 4:47

GoogleCodeExporter commented 8 years ago
It's okay. Visual Studio was kind enough to convert all those line endings for 
me automatically. Still getting used to this DVCS stuff. Thanks for the quick 
response.

Original comment by Striplin...@gmail.com on 2 Sep 2011 at 4:26