Enforce CancellationToken in ActionBase and Derived Classes - Githubissues

asulwer / RulesEngine

Rules Engine with extensive Dynamic expression support

MIT License

6 stars 1 forks source link

Enforce CancellationToken in ActionBase and Derived Classes #1

Closed RenanCarlosPereira closed 1 week ago

RenanCarlosPereira commented 1 week ago

Description: This pull request introduces a breaking change to the ActionBase class, requiring all derived classes to pass a CancellationToken parameter. The Run method in ActionBase now mandates a CancellationToken parameter.

Changes:

Updated ActionBase class to require a CancellationToken in the Run method.
Update the documentation to reflect the ActionBase class

Impact:

All derived classes must be updated to include the CancellationToken parameter in their Run method implementations.

Action Required:

Review and update all derived classes to comply with the new method signature.
Test the changes to ensure proper handling of CancellationToken in all relevant actions.

asulwer commented 1 week ago

i am reviewing this now. looks good to go as far as i can see