search

asulwer / RulesEngine

Rules Engine with extensive Dynamic expression support
MIT License
26 stars 1 forks source link

demonstrate Actions; additional ways to use Actions have been commented out #54

Closed asulwer closed 4 months ago

asulwer commented 4 months ago

https://github.com/asulwer/RulesEngine/issues/53

asulwer commented 4 months ago

attempting to come up with possible solutions for an issue

RenanCarlosPereira commented 4 months ago

Is it better to add the demo of what we have in the documentation?

https://microsoft.github.io/RulesEngine/#outputexpression

asulwer commented 4 months ago

yes that is better. i will change

RenanCarlosPereira commented 4 months ago

hey @asulwer this PR is to add the demo, isn't it? lets open another one explaining why we are adding other stuffs.

I will open a proposal PR talking about it, lets keep this one for the demo as the title says

asulwer commented 4 months ago

well it was in response to the issue and grew as he added more info

RenanCarlosPereira commented 4 months ago

yeah, I see... if you want to maintain the ToExpando method you created, we need to cover it under the unit tests. so we don't reduce the code coverage 🙌