asummers / erlex

Convert Erlang style structs and error messages to equivalent Elixir.
Other
34 stars 16 forks source link

doc: Misc. doc, README changes #52

Closed kianmeng closed 3 years ago

kianmeng commented 3 years ago

List of changes:

asummers commented 3 years ago

Wonderful! Thank you.

asummers commented 3 years ago

And this exposed a bug in my actions too. Fun times.

kianmeng commented 3 years ago

And this exposed a bug in my actions too. Fun times.

Actions? As in GitHub Actions or? I've also noticed there are three CI setup, Travis CI, Circle CI, and GitHub Actions. Which is the current CI for this repo? :smile:

Perhaps another PR to remove legacy CIs ?

asummers commented 3 years ago

Github Actions is the current one, but it's kind of half in, currently (got busy over the holidays as I was working on it). Eventually I will remove Circle and Travis entirely.

It didn't pick up your PR because I think I have it set to only grab commits to this repo and yours was a fork, I think.

kianmeng commented 3 years ago

Github Actions is the current one, but it's kind of half in, currently (got busy over the holidays as I was working on it). Eventually I will remove Circle and Travis entirely.

It didn't pick up your PR because I think I have it set to only grab commits to this repo and yours was a fork, I think.

I see. Do you know what bugs it exposed in the repo's GitHub Actions? I've checked the workflows, https://github.com/asummers/erlex/actions, seems to be passing?