asutherland / ni-controllers-lib

Modernized fork of met5678/node-traktor-f1 to support Maschine Mk3, Maschine Mk2 mikro, Traktor D2, and Traktor F1 Native Instruments controllers. Probably can support others too!
24 stars 7 forks source link

Missing LED mappings for Maschine MK3 #10

Open dkzeb opened 4 months ago

dkzeb commented 4 months ago

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch ni-controllers-lib@1.2.3 for the project I'm working on. The Maschine MK3 configuration was missing mappings for the "mixer", "browserPlugin" and "sampling" LEDs

diff --git a/node_modules/ni-controllers-lib/dist/lib/maschine_mk3_config.json b/node_modules/ni-controllers-lib/dist/lib/maschine_mk3_config.json
index 0c021ef..a07ea15 100644
--- a/node_modules/ni-controllers-lib/dist/lib/maschine_mk3_config.json
+++ b/node_modules/ni-controllers-lib/dist/lib/maschine_mk3_config.json
@@ -759,9 +759,15 @@
             "arranger": {
                 "addr": 3
             },            
-            "browserPlugin": {
+            "mixer": {
                 "addr": 4
             },
+            "browserPlugin": {
+                "addr": 5
+            },
+            "sampling": {
+                "addr": 6
+            },
             "arrowLeft": {
                 "addr": 7
             },

This issue body was partially generated by patch-package.

asutherland commented 4 months ago

Thanks for filing the issue! It seems we do have a (mis-named) sampler entry in the indexed_leds section so this probably needs a little more investigation to figure out if any of these are multi-color or not, but it's definitely clear there's a gap/errors here.

I should be able to get to this in the next few weeks, but would be happy to accept a pull request.

dkzeb commented 4 months ago

Sure :) i actually found this lib while i was preparing to build my own, so you saved me a ton of work ;) - i'll take a look at submitting a PR ;)