Input element not working

claudchan commented 8 years ago

Hi, Any way can exclude action elements such as input fields, buttons, etc...? Will be great if implement options or api to use.

jonathan-vallet commented 8 years ago

Hi,

I have made a little update to prevent click when user has drag content from a link, I think it could work with buttons too. I didn't have permissions to make a PR. Here is the new code. Feel free to update the lib if you think it's useful.

var dragged = [];
var reset = function(i, el) {
    for (i = 0; i < dragged.length;) {
        el = dragged[i++];
        el = el.container || el;
        el[removeEventListener](mousedown, el.md, 0);
        _window[removeEventListener](mouseup, el.mu, 0);
        _window[removeEventListener](mousemove, el.mm, 0);
        _window[removeEventListener](click, el.cl, 0);
    }

    // cloning into array since HTMLCollection is updated dynamically
    dragged = [].slice.call(_document.getElementsByClassName('dragscroll'));
    for (i = 0; i < dragged.length;) {
        (function(el, lastClientX, lastClientY, pushed, scroller, cont){
            (cont = el.container || el)[addEventListener](
                mousedown,
                cont.md = function(e) {
                    if (!el.hasAttribute('nochilddrag') ||
                        _document.elementFromPoint(
                            e.pageX, e.pageY
                        ) == cont
                    ) {
                        pushed = 1;
                        hasMove = false;
                        lastClientX = e.clientX;
                        lastClientY = e.clientY;

                        e.preventDefault();
                    }
                }, 0
            );

            _window[addEventListener](
                mouseup, cont.mu = function() {pushed = 0;}, 0
            );

            _window[addEventListener](
                mousemove,
                cont.mm = function(e) {
                    if (pushed) {
                        hasMove = true;
                         (scroller = el.scroller||el).scrollLeft -=
                             (- lastClientX + (lastClientX=e.clientX));
                         scroller.scrollTop -=
                             (- lastClientY + (lastClientY=e.clientY));
                    }
                }, 0
            );

            _window[addEventListener](
                click,
                cont.cl = function(e) {
                    if(hasMove) {
                        e.preventDefault();
                    }
                }, 0
            );
         })(dragged[i++]);
    }
}

if (_document.readyState == 'complete') {
    reset();
} else {
    _window[addEventListener]('load', reset, 0);
}

exports.reset = reset;

}));

claudchan commented 8 years ago

Doesn't work.