Fix intuitive propagation behavior

asvd / dragscroll

micro library for drag-n-drop scrolling style

http://asvd.github.io/dragscroll/

MIT License

1.1k stars 166 forks source link

Fix intuitive propagation behavior #52

Open zach-capalbo opened 5 years ago

zach-capalbo commented 5 years ago

Add small threshold to begin dragging
Don't propagate clicks to scrolled element after movement has reached threshold
- Useful if you are scrolling something with lots of links or buttons in it
Don't propagate mousedown events
- Useful if you have .dragscrolls embedded in other .dragscrolls

These changes break current behavior, and add a few more bytes, but it makes the behavior a lot more intuitive to me. Creating the pull request in case it seems more intuitive to anyone else.

Metis77 commented 5 years ago

this works perfectly for me. I suggest to merge this.

laurenwithcats commented 4 years ago

This worked really well as a fix on a sliding navigation bar, where navigation clicks were being incorrectly detected as drags in some cases.

jonasgoddeeris commented 2 years ago

+1 for the works really well! SHOULD MERGE!

xandeadx commented 11 months ago

Worked