search

asvd / jailed

execute untrusted code with custom permissions
MIT License
1k stars 73 forks source link

loading.gif, add contenteditable to input, add quotes #39

Closed 8V017UW2RQ70 closed 7 years ago

8V017UW2RQ70 commented 7 years ago
  1. loading.gif was missing. Used an image from loadinggif.com...

  2. input_data div was not editable, added contenteditable=true.

  3. Lack of double quotes around attribute values breaks in Sublime (esp IDs). using no quotes does not support multiple attribute values (so quotes have to be used anyways), has the potential of being used as an XSS entry, yet is mostly valid HTML and I'm not lecturing, the file is part of an example. I added double quotes because I needed to add multiple classes to some elements/attributes, and as you know, multiple attribute values must be enclosed by quotes (double or single). Orig: <div class="code intence" id=code contenteditable=true scrollImg=scroll.png></div> Prop: <div class="code intence" id="code" contenteditable="true" scrollImg="scroll.png"></div>
asvd commented 7 years ago

Thanks for the effort.

Process demo is not yet completed, because it depends on the syntax highlighting library which I am currently working on. Therefore I will not merge your request for now.

According to my thoughts for the future:

  1. Loading will be indicated not by a gif, but with a special css-based indicator;
  2. Input data is not supposed to be editable, it is re-generated when you click on it;
  3. Interesting point on quotes, I will take it into consideration for the future.
8V017UW2RQ70 commented 7 years ago

No worries. loading.gif not found was an error in the console when testing the demo, looks like /process/application.js line 36 is calling for loading.gif.