asvd / microlight

highlights code in any programming language
http://asvd.github.io/microlight
MIT License
1.48k stars 63 forks source link

Css based #6

Closed zeraphie closed 8 years ago

zeraphie commented 8 years ago

A second branch which has the choice for the user of microlight to change the styles according to their tastes - see Readme

asvd commented 8 years ago

Thanks for your suggestion. I'm not going to merge this, because the fact that colours are calculated automatically (and there is no need to tune-up the CSS) is a feature of microlight (the simplicity of API), which I would like to keep. Besides, with your changeset you ruin the original styling of microlight, and let a user decide, how to style the code. And he will likely have worse taste (comparing to mine).

If you are going to maintain your changeset as a fork of microlight, you can also remove the colour calculations (the pxColor variable and related).

asvd commented 8 years ago

http://codepen.io/zephyr/pen/MewjYd

zeraphie commented 8 years ago

Heya, didn't actually expect this to get in, kind of wanted to let you know of this version :) I've done some updating to basically make it installable as well, thanks for letting me know about the other stuff though, didn't have much time to go in depth into it to really make it css selector based.

I know that you wanted to make this without using css selectors~ just thought it would be good to have an alternative version, I'll keep this up to date with your code as well :)