asyml / texar-pytorch

Integrating the Best of TF into PyTorch, for Machine Learning, Natural Language Processing, and Text Generation. This is part of the CASL project: http://casl-project.ai/
https://asyml.io
Apache License 2.0
745 stars 117 forks source link

To get the __len__, should pass self._current_dataset_name to _valida… #334

Closed limberc closed 2 years ago

limberc commented 3 years ago

Pass self._current_dataset_name to self._validate_dataset_name. Or it would get error when calling len.

gpengzhi commented 3 years ago

Thank you very much for contributing to texar-pytorch! Could you fix the CI error at first? It seems to be a pylint error.

************* Module texar.torch.data.data.data_iterators
texar/torch/data/data/data_iterators.py:559:0: C0301: Line too long (91/80) (line-too-long))
limberc commented 3 years ago

I have deleted the whitespace according to @huzecong

gpengzhi commented 3 years ago

Hi @limberc, thanks for your contributions! Could you resolve the lint errors mentioned above?

huzecong commented 2 years ago

This was addressed in #351, so I'm closing this PR. Thanks anyway for your contribution!