search

asyml / texar-pytorch

Integrating the Best of TF into PyTorch, for Machine Learning, Natural Language Processing, and Text Generation. This is part of the CASL project: http://casl-project.ai/
https://asyml.io
Apache License 2.0
744 stars 118 forks source link

remove key #336

Closed hunterhector closed 3 years ago

hunterhector commented 3 years ago

This PR removes a private key for security reasons.

huzecong commented 3 years ago

You probably want to rewrite history using bfg and force-push. Otherwise the key stays in commit history forever.

hunterhector commented 3 years ago

You probably want to rewrite history using bfg and force-push. Otherwise the key stays in commit history forever.

Good suggestion, I think the key is actually just a public key so there is no real security threat. But we are not using it anymore so we remove it. Do you think it is necessary in danger of making problems on git history?

huzecong commented 3 years ago

Ah okay then it's probably fine. 😛