asyml / texar-pytorch

Integrating the Best of TF into PyTorch, for Machine Learning, Natural Language Processing, and Text Generation. This is part of the CASL project: http://casl-project.ai/
https://asyml.io
Apache License 2.0
745 stars 117 forks source link

Complete error message #345

Closed zhanyuanucb closed 3 years ago

zhanyuanucb commented 3 years ago

The previous error message is confusing. Even though a user passes in kwargs , since allow_new_hparam is set toFalse, the error message will still say that Only hyperparameters named 'kwargs' hyperparameters can contain new entries undefined in default hyperparameters.

codecov[bot] commented 3 years ago

Codecov Report

Merging #345 (09a02be) into master (dae9a8f) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #345   +/-   ##
=======================================
  Coverage   80.43%   80.43%           
=======================================
  Files         135      135           
  Lines       11359    11359           
=======================================
  Hits         9137     9137           
  Misses       2222     2222           
Impacted Files Coverage Δ
texar/torch/hyperparams.py 86.95% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dae9a8f...09a02be. Read the comment docs.