search

asyml / texar

Toolkit for Machine Learning, Natural Language Processing, and Text Generation, in TensorFlow. This is part of the CASL project: http://casl-project.ai/
https://asyml.io
Apache License 2.0
2.39k stars 374 forks source link

Minor Fix on seq2seq_attn #256

Closed gpengzhi closed 4 years ago

gpengzhi commented 4 years ago

tf.flags cannot handle options containing a hyphen in the middle. Use argparse instead.

ZhitingHu commented 4 years ago

I don't think this change is necessary. All Texar-TF examples use tf.flags and use underlines instead of hyphen. Let's keep this unchanged/consistent to avoid confusion... Indeed the inconsistency between the conventions of Texar-TF's flags (using underline) and Texar-PyTorch (using hyphen) has caused confusion for some of the users

codecov[bot] commented 4 years ago

Codecov Report

Merging #256 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #256   +/-   ##
=======================================
  Coverage   80.56%   80.56%           
=======================================
  Files         188      188           
  Lines       13121    13121           
=======================================
  Hits        10571    10571           
  Misses       2550     2550

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 44e335e...ea45297. Read the comment docs.