search

async-email / async-smtp

Apache License 2.0
59 stars 12 forks source link

Do not expose the hostname to the server, just make it localhost #27

Closed Hocuri closed 4 years ago

Hocuri commented 4 years ago

I run the dc python remote tests on this and, no surprise, they ran fine. Fix https://github.com/async-email/async-smtp/issues/25 fix https://github.com/deltachat/deltachat-core-rust/issues/1728

dignifiedquire commented 4 years ago

Can you please test with the major email providers, that this does not result in any blocks? There are some references that if this hostname is incorrect, it can result in spam blockages.

Hocuri commented 4 years ago

I'll do this but isn't the hostname just some random name the user or the vendor chose?

dignifiedquire commented 4 years ago

I'll do this but isn't the hostname just some random name the user or the vendor chose?

It is not, it is supposed to be a dns name that resolves to the public IP of the sender, or the actual public IP.

Hocuri commented 4 years ago

I tested with Gmail, Yahoo and Posteo now and all worked fine. Is this enough?

dignifiedquire commented 4 years ago

I tested with Gmail, Yahoo and Posteo now and all worked fine. Is this enough?

Seems reasonable, if we run into issues we can change it again