jocutajar commented 4 years ago

33 streaming API compiles and unit tests, test drive pending

Removed 'a lifetime from Transport, was it needed?
File transport modified to do only headers in JSON, body in raw (breaking change). Can be made into compatible solution if needed, but I assume it is for testing.
Refactored strongly the SmtpClient and InnerClient to be able to adapt to new API
Transport trait reduced to StreamingTransport, extra features are in new Transport.
Split SmtpTransport from smtp_client module into transport module as the file was getting huge

The interface should not break for normal users of the lib. If there is someone implementing the public traits though, they would have to adjust.

link2xt commented 4 years ago

Related post here with rationale for the change: https://support.delta.chat/t/smtp-server-samotop/1177/5

jocutajar commented 4 years ago

Green at last, trying it in Samotop. For now stopped on Future not being Sync. Sounds like another refactoring of Samotop is due - https://gitlab.com/BrightOpen/BackYard/Samotop/-/blob/feature/lmtp/samotop-to-lmtp/src/lib.rs#L156 Bright futures :) I've learned from your code, for instance how to use the async trait. On a side note, we are solving some very similar problems, like STARTTLS upgrade...

hpk42 commented 2 years ago

seems to out of date as well.

async-email / async-smtp

Feature/jo/#33 streaming api #34

33 streaming API compiles and unit tests, test drive pending