search

async-interop / event-loop

An event loop interface for interoperability in PHP.
MIT License
169 stars 9 forks source link

Add warning about locally closed resources being undefined behavior #109

Closed kelunik closed 8 years ago

kelunik commented 8 years ago

Also makes Loop docs consistent with Driver. Resolves #106.

kelunik commented 8 years ago

Forgot to copy defer, delay, repeat from Driver to Loop. Also replaced may with MAY and rebased onto master.

bwoebi commented 8 years ago

Feel free - would be consistent with the other text.

Bob Weinand (iPhone)

Am 25.10.2016 um 12:21 schrieb Niklas Keller notifications@github.com:

@kelunik commented on this pull request.

In src/Loop/Driver.php:

@@ -81,9 +81,9 @@ * Execute a callback when a stream resource becomes readable or is closed for reading. \ Warning: Closing resources locally, e.g. with fclose, might not invoke the callback. Be sure to cancel the

  • * watcher when closing the resource locally. Drivers might choose to notify the user in a debug mode if there are
  • * watchers on invalid resources, but are not required to, due to the high performance impact. Watchers on closed
  • * resources are therefore undefined behavior.
  • * watcher when closing the resource locally. Drivers may choose to notify the user if there are watchers on invalid Maybe we should write MAY

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

kelunik commented 8 years ago

That's a bit late.