Make use of PHP 7 features

async-interop / event-loop

An event loop interface for interoperability in PHP.

MIT License

169 stars 9 forks source link

Make use of PHP 7 features #122

Closed kelunik closed 7 years ago

kelunik commented 7 years ago

Adds scalar type declarations and return type declarations. Increases the minimum version of PHP to 7.0.0.

We can discuss whether we make the error handler an interface now, as we have anonymous classes.

Relates to #2.

kelunik commented 7 years ago

Does anybody know the current state of PHP 7 features implemented in HHVM? Do we care about HHVM?

WyriHaximus commented 7 years ago

Does anybody know the current state of PHP 7 features implemented in HHVM? Do we care about HHVM?

HHVM doesn't expose itself to as PHP 7 to composer table flips when you try to run composer install on it. Didn't go any further and pretty much dropping HHVM from my PHP 7 only package over the last months because of that. No idea what PHP 7 features they would support

bwoebi commented 7 years ago

Can you please PR the fixes separately (like detatch => detach, $time => $msDelay etc.)?

kelunik commented 7 years ago

Closing as of https://github.com/async-interop/event-loop/issues/2#issuecomment-269646468.