How to count in getInfo

async-interop / event-loop

An event loop interface for interoperability in PHP.

MIT License

169 stars 9 forks source link

How to count in getInfo #131

Closed kelunik closed 7 years ago

kelunik commented 7 years ago

Reading https://github.com/WyriHaximus/reactphp-async-interop-loop/blob/33a8bfa/src/ReactEventLoop.php#L491-L499, should referenced / unreferenced include all watchers or only enabled ones?

bwoebi commented 7 years ago

Without checking what we do or what they do, I'd intuitively only consider enabled ones. It doesn't provide much information to have disabled refd/unrefd info.

WyriHaximus commented 7 years ago

FYI IIRC I pretty much copied that over from AMP when writing that at the time, highly likely with some changes though :blush:

bwoebi commented 7 years ago

Closing as #135 has been merged.