search

async-interop / event-loop

An event loop interface for interoperability in PHP.
MIT License
169 stars 9 forks source link

Use a simple get/set accessor instead #149

Closed bwoebi closed 7 years ago

bwoebi commented 7 years ago

As we ended up disagreeing on a common global accessor, I propose simplifying the whole accessor to just a get()+set() method pair.

This ensures that the loop will be interoperable at all (otherwise we'd end up having different loops active or worse things).

Now, every library can choose its own accessors as desired. This should resolve the current point of contention.

Is this something we all can agree on? \cc @kelunik @trowski @clue @WyriHaximus @martinschroeder @jsor @cboden @davidwdan @mbonneau @rdlowrey (please leave a thumbs up or down)

After that, I guess we can relatively quickly go to tagging v1 then as I haven't seen much objection on the Driver interface itself at all.

WyriHaximus commented 7 years ago

Looks good :+1:

Regarding driver specs and feedback I'll ask @clue and @cboden to respond with feedback or give me a list (if any).

bwoebi commented 7 years ago

@WyriHaximus There seems to be general approval to this PR…

So, looking forward to the feedback from @clue and @cboden, then I'll merge this if we can agree on everything (also Driver).

cboden commented 7 years ago

I have a busy week at work. I'll take a look as soon as I can which probably won't be until the weekend.

bwoebi commented 7 years ago

A quick reminder @cboden :-)

kelunik commented 7 years ago

Closing, as project discontinued for now.