Line Length and Code Formatting

[AndrewCarterUK]

We've pretty much cleared the issue and pull request queue now.

One of the tasks we were saving to this point is the line length on the phpdoc and when to wrap. I'm happy to go with any limit as long as we are consistent and it's not ridiculous (I can read it on GitHub without scrolling or wrap).

[bwoebi]

I can display ~140 chars on github … so, what about a (soft) limit of 120 chars and hard limit of 130 chars?

[AndrewCarterUK]

Sounds reasonable. Question for everyone - where does this snippet cut off on your screen:

https://github.com/async-interop/event-loop/blob/master/src/Loop/Driver.php#L29-38

    /**
     * Defer the execution of a callback.
     *
     * The deferred callable MUST be executed in the next tick of the event loop and before any other type of watcher. Order of definition MUST be preserved when executing the callbacks.
     *
     * @param callable(string $watcherId, mixed $data) $callback The callback to defer. The $watcherId will be invalidated before the callback call.
     * @param mixed $data Arbitrary data given to the callback function as the $data parameter.
     *
     * @return string An unique identifier that can be used to cancel, enable or disable the watcher.
     */
    public function defer(callable $callback, $data = null);

[bwoebi]

Uhm, github issues view is smaller, so for reference here: https://github.com/async-interop/event-loop/blob/master/src/Loop/Driver.php#L33

I see until "before the callbsnip"

[AndrewCarterUK]

On the comment it cuts off after "... the event loop and before...cuts" On the source file it cuts off after "... watcher. Order of defcuts"

[bwoebi]

That particular line is "Order of definition cuts" for me (in source)

[kelunik]

[assertchris]

Don't know if it's been mentioned elsewhere, but http://www.php-fig.org/psr/psr-2/#1-overview

[bwoebi]

soft limit of 120 chars is nothing else than what I've suggested … but that's really just coincidence as I don't really care about PSR-2…

[assertchris]

I'm just mentioning PSR-2 as it addresses this question. I don't think we've agreed (as a group) to ignore PSR-2, so I think it's relevant. Please be more courteous. :)

[bwoebi]

Sorry, too annoyed by the braces on following line … nothing personal, only sometimes angered about this PSR-2 thing ^_^

[assertchris]

I hate the inconsistencies too... :/

[kelunik]

I don't think we've agreed (as a group) to ignore PSR-2, so I think it's relevant. Please be more courteous. :)

Until now, we also didn't agree to follow PSR-2. ;-)

[assertchris]

@kelunik and I'm not suggesting we do. But it's still relevant to the discussion...

[kelunik]

I opened an issue to discuss this separately.

[kelunik]

I don't really understand PSR-2 here. Isn't SHOULD already the soft limit? Why is there a second soft limit as 120?

[sagebind]

Sorry, too annoyed by the braces on following line … nothing personal, only sometimes angered about this PSR-2 thing ^_^

You seem more overworked about it than necessary. It's only code formatting. I care more about what the code is than what it looks like.

120 seems like a reasonable wrap limit to me.

[WyriHaximus]

120 is very reasonable limit, even before that the longer a line gets the harder it becomes to read (rule of thumb, there are exceptions)

[bwoebi]

I've looked right now, there are no overlong lines left; closing.

[kelunik]

We still need to adjust the shorter ones to be consistent.