search

async-interop / event-loop

An event loop interface for interoperability in PHP.
MIT License
169 stars 9 forks source link

Naming conventions #96

Closed kelunik closed 7 years ago

kelunik commented 8 years ago

This issue relates to #11. Looks like this vote doesn't pass: https://groups.google.com/d/msg/php-fig/S-URR0_h2U0/1hpJhkgiDwAJ. If we want this standard to be a FIG standard, we have to adjust our class names.

We also might want to follow other PSRs and use exception interfaces instead of classes. We might even want to do that independently.

bwoebi commented 8 years ago

We do not have to be integrated into FIG either. Async-Interop can as well just reside as defacto standard between the different Loop implementations.

FIG is really just a way to make things "more official".

Let's defer this until we know whether we'll be in FIG or not.

I haven't understood the point of using Exception interfaces. I mean, I can just trivially extend the class instead, in case I really want my own class. For everything else we can just easily use the exceptions defined here without an extra class in the codebase implementing event-loop.

kelunik commented 7 years ago

Following the discussion in #11 there seems to be consensus to keep our current names, no matter what happens with FIG.