search

async-labs / builderbook

Open source web application to learn JS stack: React, Material-UI, Next.js, Node.js, Express.js, Mongoose, MongoDB database.
https://builderbook.org
MIT License
3.76k stars 893 forks source link

Sign in with Google. / Google OAuth API Infrastructure #515

Closed reingoldkz closed 1 year ago

reingoldkz commented 1 year ago

Hi async-labs team!

https://developers.google.com/identity/sign-in/web/sign-in

As we see from this google article, Google Sign in is deprecated and urging us to use new Sign in with Google.

My question: if we doing builderbook project from scratch will the code work fine? Is book content relevant at the moment?

Thanks for your job.

tima101 commented 1 year ago

@reingoldkz If I click on depreciated link inside the article you linked to, it says:

The deprecation applies only to web apps using the Google Sign-in JavaScript library. If your web pages currently load the Google Platform Library ([apis.google.com/js/platform.js](http://apis.google.com/js/platform.js)), you are affected and need to migrate to the newer Sign In With Google client library.

From: https://developers.googleblog.com/2021/08/gsi-jsweb-deprecation.html

Since passport, passport strategy and our code do not call /platform.js and do not use "Google Sign-in JavaScript library" - our codebase is not affected. Also see https://github.com/async-labs/builderbook/issues/458