async-labs / saas

Build your own SaaS business with SaaS boilerplate. Productive stack: React, Material-UI, Next, MobX, WebSockets, Express, Node, Mongoose, MongoDB. Written with TypeScript.
https://saas-app.async-await.com
MIT License
4.06k stars 674 forks source link

Contribution #170

Closed athahersirnaik closed 2 years ago

athahersirnaik commented 2 years ago
  1. Shall we move the env variables to .env.example instead of Readme
  2. I'm working on adding additional email driver like smtp and log that can be controlled by .env
  3. Instead of checking dev environment eveytime, we can use config. Let me know if I should create PR for this?
tima101 commented 2 years ago

@athahersirnaik Hi, thanks for suggestions. We plan to keep AWS SES infrastructure for emails, no plans to add other options. And config seems to add more configuration than necessary. You can do your own email implementation on your fork. As for 1), seems like a good idea.

athahersirnaik commented 2 years ago

Ok, I'm adding config in my fork, you can check it if you want the same, then I'll create a PR