async-labs / saas

Build your own SaaS business with SaaS boilerplate. Productive stack: React, Material-UI, Next, MobX, WebSockets, Express, Node, Mongoose, MongoDB. Written with TypeScript.
https://saas-app.async-await.com
MIT License
4.11k stars 682 forks source link

NProgress code does not work as shown #180

Closed michaelklem closed 2 years ago

michaelklem commented 2 years ago

https://builderbook.org/books/saas-boilerplate/material-ui-client-side-and-server-side-rendered-pages-dark-theme-cssbaseline-shared-layout-adding-styles-shared-components-menuwithlinks-notifier-confirmer-nprogress-mobile-browser#nprogress

I ended up using this npm module "@tanem/react-nprogress" and I needed to add more components I copied from an react-nprogress example to get working.

I can provide files as needed or give you access to my code.

klyburke commented 2 years ago

@michaelklem Thanks for reporting.

Can you please explain in more detail what you mean by "does not work as shown"?

I ran 2-end and clicked the Test Confirmer and Notifier button. I then see the progress bar run at the top of the page.

Yes, if you'd like to create a public repo with the exact code you are running, I can look at that.

michaelklem commented 2 years ago

You are correct. Your code works. The use of NProgress.done() prevented me from seeing the progress bar enough.

On Thu, Aug 25, 2022 at 3:06 PM Kelly Burke @.***> wrote:

@michaelklem https://github.com/michaelklem Thanks for reporting.

Can you please explain in more detail what you mean by "does not work as shown"?

I ran 2-end and clicked the Test Confirmer and Notifier button. I then see the progress bar run at the top of the page.

Yes, if you'd like to create a public repo with the exact code you are running, I can look at that.

— Reply to this email directly, view it on GitHub https://github.com/async-labs/saas/issues/180#issuecomment-1227807123, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEQIO7NWLNDZIR2VOGZE4DV27U5TANCNFSM57RFPIWA . You are receiving this because you were mentioned.Message ID: @.***>

klyburke commented 2 years ago

@michaelklem Thanks for following up!