search

async-labs / saas

Build your own SaaS business with SaaS boilerplate. Productive stack: React, Material-UI, Next, MobX, WebSockets, Express, Node, Mongoose, MongoDB. Written with TypeScript.
https://saas-app.async-await.com
MIT License
4.12k stars 684 forks source link

Ch. 1 - book/1-end/app, I think it was supposed to be book/1-begin/app #90

Closed mrhanson3 closed 4 years ago

mrhanson3 commented 4 years ago

"These rules are listed in a tsconfig.json file. Go to book/1-end/app and create tsconfig.json with following content:"

This is already in the book/1-end/app, so I think it was supposed to say book/1-begin/app.

Do y'all care about this type of input? If not, no worries.

ElijahElrod commented 4 years ago

This happens multiple times throughout chapter 2, In chapter two: 'Inside book/2-end/app/lib/, create a theme.ts file with following content:', 'Add all three changes to your current book/2-end/app/pages/_app.tsx. You will get:'

klyburke commented 4 years ago

Thank you @mrhanson3 and @ElijahElrod! I reviewed those 3 items and corrected them.

@ElijahElrod, I confirm the multiple instances in chapter 2. I went through chapter 2 and corrected all places where we should have -begin instead of -end. I'll check through the other chapters as well.

@mrhanson3 we do appreciate this feedback!

klyburke commented 4 years ago

@mrhanson3 @ElijahElrod Thanks again for bringing up this issue. I corrected all cases in the book where we wrote -end/ but meant -begin/