async-rs / async-tls

A TLS implementation over AsyncRead and AsyncWrite
https://async.rs
Apache License 2.0
167 stars 47 forks source link

Doesn't build with rustc 1.73 #56

Open sdroege opened 8 months ago

sdroege commented 8 months ago
error[E0446]: crate-private type `Conn<'a>` in public interface
  --> src/rusttls/stream.rs:13:5
   |
13 |     pub conn: Conn<'a>,
   |     ^^^^^^^^^^^^^^^^^^ can't leak crate-private type
...
17 | pub(crate) enum Conn<'a> {
   | ------------------------ `Conn<'a>` declared as crate-private

error[E0446]: crate-private type `Conn<'a>` in public interface
   --> src/rusttls/stream.rs:127:5
    |
17  | pub(crate) enum Conn<'a> {
    | ------------------------ `Conn<'a>` declared as crate-private
...
127 |     pub fn new(io: &'a mut IO, conn: impl Into<Conn<'a>>) -> Self {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ can't leak crate-private type

This is just cargo +1.73 check in this repository.

dignifiedquire commented 8 months ago

which version are you using? I can build master with 1.75 without issues

sdroege commented 8 months ago

1.73. It builds fine with 1.75

dignifiedquire commented 8 months ago

very strange

sdroege commented 8 months ago

It's the same with 1.70, FWIW. I don't have older versions of the toolchain installed right now.