search

async-rs / parallel-stream

Data parallelism library for async-std.
https://docs.rs/parallel-stream
Apache License 2.0
93 stars 16 forks source link

Does not compile with latest async-std and additional compilation errors #22

Closed ethindp closed 3 years ago

ethindp commented 3 years ago

This crate does not compile with the latest version of async-std (v. 1.10.0). I'd fix it but am unsure what I'll break, so I'm filing it as an issue here before I file a PR. Specifically, the following changes have been made in async-std 1.10.0 that break the crate:

Furthermore, par_stream/map.rs defines Map<T>, but parameter T is never used (error E0392).

Compiling with rustc 1.57.0-nightly (2c7bc5e33 2021-09-15).

yoshuawuyts commented 3 years ago

Oops, yeah the stream breakage will do it. We should indeed switch that implementation over. It seems like https://github.com/async-rs/parallel-stream/pull/21 contains a partial fix for this which we should probably use.

yoshuawuyts commented 3 years ago

published a new version which fixes this!