asyncLiz / minify-html-literals

Minify HTML template literal strings
MIT License
68 stars 14 forks source link

Fix placeholder splitting #21

Closed gerriet-hinrichs closed 4 years ago

gerriet-hinrichs commented 4 years ago

Update splitting by not just simply using the placeholder itself but by making it context aware:

Fixes #18 and #20

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 69


Totals Coverage Status
Change from base Build 63: 0.2%
Covered Lines: 85
Relevant Lines: 92

💛 - Coveralls
asyncLiz commented 4 years ago

Thanks for the PR! I appreciate the contribution 🙂

The underlying issue for this has actually already been solved as part of the html template adjusting the CSS minify options to compensate for the semicolon being removed from the placeholder.

The same logic is not being applied to the css template minify options. I've created https://github.com/asyncLiz/minify-html-literals/pull/22 that should address that issue and fix the two issues you've created.

Because of that, I'm going to go ahead and close this PR in favor of the other one. But thank you again for the detailed test cases and issues!