ready_for_review : Update package-lock.json

naman-tiwari commented 2 years ago

Can the mentors please review my PR

mcturco commented 2 years ago

Hi @naman-tiwari! A few things:

It would help give context to your changes if you updated the description of the PR explaining why the changes are necessary
You are missing the Lint title in the PR, (see here for breakdown of available ones) Looks like you are updating packages so might be best to go with the build: title prefix
Not sure that we need the .vscode files and I think that they should probably be added to .gitignore. Keep in mind that not everyone uses vscode as an IDE, so unless this file absolutely has to be part of the base repo, I would say to remove it.

It might help to have @magicmatatjahu's feedback here as well 😄

naman-tiwari commented 2 years ago

Ok @mcturco . I will mention this.

naman-tiwari commented 2 years ago

I will close this pull request as of now.

I saw some vulnerabilities in package-lock.json and I guess I have messed up while creating this PR.
Will mention all the parameters from next time onwards.@fmvilas

I ran these commands in vs code:

npm run storybook

npm audit

npm audit fix

fmvilas commented 2 years ago

Sounds good. No problem 👍

asyncapi-archived-repos / design-system