Closed fuzza closed 6 years ago
Hi @fuzza. Thanks for reporting. Absolutely, your PR is more than welcome!
Was this fix already pushed to the online editor? I saw similar problems. If yes, please update if no there are still problems.
@NicoHood @fuzza it's already working on the Editor. I also published the fix to npm (version 1.10.2): https://www.npmjs.com/package/asyncapi-docgen.
Thanks for the PR @fuzza!
It seems that there is an issue with rendering of required properties of SchemaObject. E.g. for a following API schema
first_field
oftestSchema
won't be rendered as a required.From what I see in
schema-prop
template, there is a check of required array existance inside theprop
object while it needs to check that parent schema object haspropName
inrequired
array.I have WIP fix for this issue in a forked repo, so please let me know if you want me to submit a PR. Looking forward for you feedback.