Upgrade checkout action to actions/checkout@v3. It is safe as they bumped from v2 to v3 only to upgrade the node runner to node 16. No breaking changes
Upgrade script action to actions/github-script@v6. There were breaking changes in v5 only, v6 was just node engine update. Only one workflow needed a refactor to github.rest
Upgrade to latest pascalgn/automerge-action. No breaking changes, just for node engine deprecation
Upgrade to latest hmarr/auto-approve-action. No breaking changes, just for node engine deprecation
Upgrade docker actions from if-docker-pr-testing.yml workflow. No breaking changes, just for node engine deprecation
Upgrade go actions from if-go-pr-testing.yml workflow. No breaking changes, just for node engine deprecation
Upgrade actions/setup-node to v3. Node engine related. There is one breaking change that do not relate to us, to use node-version input instead of version - but that was always done
Upgrade to latest peter-evans/create-pull-request. There are some breaking changes related to add-paths but we are no using it. We need to upgrade because of node enginge
Upgrade to latest amannn/action-semantic-pull-request because of node.
Upgrade to latest marocchino/sticky-pull-request-comment - node
Upgrade to latest derberg/npm-dependency-manager-for-your-github-org - node
Upgrade to latest m1ner79/Github-Twittction -node
removal of one action
Remove sentiment-analysis.yml - it will not work because of node deprecation. The fact is that this action is not working for few months already, it was never good because of lack of context and was 100% of time causing false positives
stop using actions-ecosystem/action-create-comment
Looks like actions-ecosystem/action-create-comment is not maintained and they did not bump version for node16. I removed it from help-command.yml and now use GitHub API directly in script action
stop using LoveToKnow/slackify-markdown-action
Unfortunately LoveToKnow/slackify-markdown-action is not very much maintained and there is a PR to change to node16 for months, not merged.
actions bumps forced by node12 -> node16:
actions/checkout@v3
. It is safe as they bumped from v2 to v3 only to upgrade the node runner to node 16. No breaking changesactions/github-script@v6
. There were breaking changes in v5 only, v6 was just node engine update. Only one workflow needed a refactor togithub.rest
pascalgn/automerge-action
. No breaking changes, just for node engine deprecationhmarr/auto-approve-action
. No breaking changes, just for node engine deprecationif-docker-pr-testing.yml
workflow. No breaking changes, just for node engine deprecationif-go-pr-testing.yml
workflow. No breaking changes, just for node engine deprecationactions/setup-node
to v3. Node engine related. There is one breaking change that do not relate to us, to usenode-version
input instead ofversion
- but that was always donepeter-evans/create-pull-request
. There are some breaking changes related toadd-paths
but we are no using it. We need to upgrade because of node engingeamannn/action-semantic-pull-request
because of node.marocchino/sticky-pull-request-comment
- nodederberg/npm-dependency-manager-for-your-github-org
- nodem1ner79/Github-Twittction
-noderemoval of one action
Remove
sentiment-analysis.yml
- it will not work because of node deprecation. The fact is that this action is not working for few months already, it was never good because of lack of context and was 100% of time causing false positivesstop using
actions-ecosystem/action-create-comment
Looks like
actions-ecosystem/action-create-comment
is not maintained and they did not bump version for node16. I removed it fromhelp-command.yml
and now use GitHub API directly in script actionstop using
LoveToKnow/slackify-markdown-action
Unfortunately
LoveToKnow/slackify-markdown-action
is not very much maintained and there is a PR to change to node16 for months, not merged.Now we do not use this action but for the first time we will use composite action -> https://github.com/asyncapi/.github/pull/226/files#diff-dacdba02324430e1c58a8c5262cf680d96abfc8ca95a5b3500cc9aa9ef10d155 I'm personally in love with composite actions and think we can optimize our CI with it a lot. Important to notice there composite actions do not have to be replicated with global workflow in multiple repos, can be referenced from this repo
this was tested in my test repo:
refactor
set-output
set-output
goes away -> https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/so they had to be refactored to a new way