asyncapi / .github

Location of all reusable community health files
29 stars 62 forks source link

ci: upgrade some actions related to planned GH deprecations #226

Closed derberg closed 1 year ago

derberg commented 1 year ago

actions bumps forced by node12 -> node16:

removal of one action

Remove sentiment-analysis.yml - it will not work because of node deprecation. The fact is that this action is not working for few months already, it was never good because of lack of context and was 100% of time causing false positives

stop using actions-ecosystem/action-create-comment

Looks like actions-ecosystem/action-create-comment is not maintained and they did not bump version for node16. I removed it from help-command.yml and now use GitHub API directly in script action

stop using LoveToKnow/slackify-markdown-action

Unfortunately LoveToKnow/slackify-markdown-action is not very much maintained and there is a PR to change to node16 for months, not merged.

Now we do not use this action but for the first time we will use composite action -> https://github.com/asyncapi/.github/pull/226/files#diff-dacdba02324430e1c58a8c5262cf680d96abfc8ca95a5b3500cc9aa9ef10d155 I'm personally in love with composite actions and think we can optimize our CI with it a lot. Important to notice there composite actions do not have to be replicated with global workflow in multiple repos, can be referenced from this repo

this was tested in my test repo:

refactor set-output

set-output goes away -> https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

so they had to be refactored to a new way

derberg commented 1 year ago

cc @KhudaDad414 please review ๐Ÿ™๐Ÿผ not an easy one

cc @14Richa would be cool if you could this time contribute as reviewer ๐Ÿ™๐Ÿผ

cc @saurav9878 maybe you wanna have a look

14Richa commented 1 year ago

@derberg , LGTM too!! :+1:

derberg commented 1 year ago

/rtm