Closed Shurtu-gal closed 5 months ago
@derberg as was discussed over slack, to not consume too much action minutes right now auto-update is only enabled for comments like \u
or /update
. Hence there is no need of filtering based on labels.
Labels were meant for filtering in case of mass updates, like in this case
Also, I had removed the previous one as I this one was sufficient for both tasks, but before we do so we have to consider amount of action minutes it will take. Furthermore, GH API limit may also be reached.
Because the API used by it requires admin access for the updation. Meanwhile, I am this mutation which basically uses a merge PR already created by GitHub (Yeah, I know it sounds unreal 😆), and applies it on top of the HEAD, this was custom made for PR branches.
the problem with saving minutes is that we have a huge amount of bot-created PRs, that quite often require autoupdating
one example: https://github.com/asyncapi/asyncapi-react/pull/924 -> by default autoupdate is added and the bot merges master in like a charm
/help
Hello, @Shurtu-gal! 👋🏼
I'm 🧞🧞🧞 Genie 🧞🧞🧞 from the magic lamp. Looks like somebody needs a hand!
At the moment the following comments are supported in pull requests:
- `/ready-to-merge` or `/rtm` - This comment will trigger automerge of PR in case all required checks are green, approvals in place and do-not-merge label is not added
- `/do-not-merge` or `/dnm` - This comment will block automerging even if all conditions are met and ready-to-merge label is added
- `/autoupdate` or `/au` - This comment will add `autoupdate` label to the PR and keeps your PR up-to-date to the target branch's future changes. Unless there is a merge conflict or it is a draft PR.
/autoupdate
/update
@derberg A successful run on comment:- https://github.com/ash17290/asyncapi-github/actions/runs/8086468906 A Successful run on push:- https://github.com/ash17290/asyncapi-github/actions/runs/8086440737
Note that only labelled PRs are auto-updated rest have to be manually done.
@Shurtu-gal I see you requested review again, but I understand you will do further refactor first right?
@derberg The refactoring has been done.
also in error messages for user, we do not write anything about merge conflicts, that in case of merge conflicts it will also not work
Added that as well.
/rtm
/help
Hello, @Shurtu-gal! 👋🏼
I'm 🧞🧞🧞 Genie 🧞🧞🧞 from the magic lamp. Looks like somebody needs a hand!
At the moment the following comments are supported in pull requests:
- `/please-take-a-look` or `/ptal` - This comment will add a comment to the PR asking for attention from the reviewrs who have not reviewed the PR yet.
- `/ready-to-merge` or `/rtm` - This comment will trigger automerge of PR in case all required checks are green, approvals in place and do-not-merge label is not added
- `/do-not-merge` or `/dnm` - This comment will block automerging even if all conditions are met and ready-to-merge label is added
- `/autoupdate` or `/au` - This comment will add `autoupdate` label to the PR and keeps your PR up-to-date to the target branch's future changes. Unless there is a merge conflict or it is a draft PR. (Currently only works for upstream branches.)
- `/update` or `/u` - This comment will update the PR with the latest changes from the target branch. Unless there is a merge conflict or it is a draft PR. NOTE: this only updates the PR once, so if you need to update again, you need to call the command again.
/update
Description
/update
comment and updates PRs pointing to it and havingautoupdate
label in it./help
to have/update
in it.Related issue(s) Fixes #227