search

asyncapi / .github

Location of all reusable community health files
29 stars 62 forks source link

ci: implemment pagination #266

Open Gmin2 opened 6 months ago

Gmin2 commented 6 months ago

Description Each co-author appear in a new line and implement pagination Related issue(s) Resolves #263

Gmin2 commented 6 months ago

TBH I am not a fan of writing this action in bash. it is hard to maintain ( I don't speak bash). 😆 can you rewrite in in almighty js?

i am too not a big fan of bash but as @smoya had mentioned in the issue to use some bash thats why i have used bash but no problem i am converting it too js cc @KhudaDad414

smoya commented 6 months ago

TBH I am not a fan of writing this action in bash. it is hard to maintain ( I don't speak bash). 😆 can you rewrite in in almighty js?

i am too not a big fan of bash but as @smoya had mentioned in the issue to use some bash thats why i have used bash but no problem i am converting it too js cc @KhudaDad414

Totally no strong opinion on using bash or any language of our preference TBH. So 👍 on my side.

Gmin2 commented 6 months ago

@KhudaDad414 @smoya should i rewrite this in js or not

derberg commented 6 months ago

@Min2who please rewrite to JS as we have a lot of experience with it and it will be much better to maintain long term.

please use https://github.com/actions/github-script action that already have pagination related plugins added so writing such script will be much better DX and also much readable ❤️

so one step will be just getting data from GitHub API (by default afaik response will be stored as part of output that you will be able to access from another step https://github.com/actions/github-script?tab=readme-ov-file#reading-step-results). And in another step you will construct a commit message.

such approach will make maintenance much better + will make is easier to debug in future

smoya commented 6 months ago

i am too not a big fan of bash

As @derberg stated, +1 to use JS. From the very moment this is not gonna be a simple one liner as it was, it will become very hard to maintain.

Gmin2 commented 6 months ago

@KhudaDad414 @derberg @smoya can you suggest me some way to test this actions locally

KhudaDad414 commented 6 months ago

@Min2who actions are a little hard to test especially this one. I would suggest testing the script you write separately and making sure it gets what you want. testing the entire workflow is a little more challenging, you may need to test it on your fork. I think testing the script here suffices.

Gmin2 commented 5 months ago

i have updated this action using the github octokit.paginate plugin and have test this in my local fork action in this

cc @smoya @KhudaDad414

Gmin2 commented 5 months ago

made the changes

cc @KhudaDad414

Gmin2 commented 5 months ago

LGTM! please wait for @derberg's review. 🙇

waiting 🙇‍♂️ cc @derberg

Gmin2 commented 4 months ago

@Min2who hey, left some comments how you can improve the action

can you share some example where did you test it, a test run?

This is my test run @derberg

derberg commented 3 months ago

@utnim2 did you see my other comments?

Gmin2 commented 3 months ago

@utnim2 did you see my other comments?

ahh sorry , working on it

Gmin2 commented 3 months ago

Done the reviewed changes

The test of this action here

cc @derberg @KhudaDad414

derberg commented 2 months ago

@utnim2 lgtm but there were some changes done since initial implementation, can you show your changes somewhere in action, in some test repo? I can help if you need someone to open a PR in your repo, and then you make edits to make sure it works