asyncapi / .github

Location of all reusable community health files
29 stars 65 forks source link

ci: add support for `next` release branch #294

Closed jonaslagoni closed 5 months ago

jonaslagoni commented 5 months ago

Description In Modelina we have been using next since the beginning, however, we decided to remove it from the official workflow 🤨 We did a patch at some point in Modelina, and then I forgot about it.

This PR adds it officially.

derberg commented 5 months ago

don't you use also a global release config for sematic-release? we need change in https://github.com/asyncapi/.github/blob/master/.github/workflows/.releaserc as well

jonaslagoni commented 5 months ago

We dont no.

jonaslagoni commented 5 months ago

In the next branch we use a much more customized version: https://github.com/asyncapi/modelina/blob/next/.releaserc

jonaslagoni commented 5 months ago

I wonder if we should just remove Modelina from getting global CI change pushes...

derberg commented 5 months ago

@jonaslagoni as long as you do not provide modifications in release workflow, I do not recommend it.

release workflows are separated from release config with topics get-global-node-release-workflows and get-global-releaserc so that is fine and you have a flexibility you need at the moment. Just please update in this PR the release config, so semantic-release for others knows what to do with merges to next

jonaslagoni commented 5 months ago

@derberg done :v:

derberg commented 5 months ago

/rtm