asyncapi / avro-schema-parser

An AsyncAPI schema parser for Avro 1.x schemas.
Apache License 2.0
32 stars 19 forks source link

chore: merge `next-major` into master #191

Closed smoya closed 1 year ago

smoya commented 1 year ago

Description

This PR merges next-major branch into master.

Warning DO NOT SQUASH. USE REBASE OR MERGE

next-major branch includes the rewrite to TypeScript and adapts to the new Parser-API interface. It is BC (see commits included with feat!: prefix).

Related issue(s) https://github.com/asyncapi/parser-js/issues/481

derberg commented 1 year ago

I really don't understand why this should not be feat!: and squash merged like any other release PR

smoya commented 1 year ago

I really don't understand why this should not be feat!: and squash merged like any other release PR

In this particular case, It is not very critical since I authored all changes in next-major branch. However, it is not a good practice to squash a long-live branch since you lose all commits history, including different commits with different authors. Additionally, minor thing here, you create a fake commit, with a wrong creation date, etc that doesn't represent the real work behind.

derberg commented 1 year ago

since you lose all commits history, including different commits with different authors

we don't loose history, it is all there. We use that approach for 3 years now and it was never a problem

you create a fake commit

it is not a fake commit, it is squash of all commits into one summary to have clean history.


also, why is this a chore: commit? we are merging here entire release branch into master

smoya commented 1 year ago

we don't loose history, it is all there. We use that approach for 3 years now and it was never a problem

If you squash commits into a single one, you lose history.

also, why is this a chore: commit? we are merging here entire release branch into master

It is chore since, if merged and not squashed, the commit feat!: implement new Parser-js interface will remain and added into master, so no need to add another feat!:

smoya commented 1 year ago

@derberg More discussion about it can be found in https://github.com/asyncapi/community/issues/641

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

smoya commented 1 year ago

Please @dalelane approve again. Had to update with base branch and your review got dismissed

M3lkior commented 1 year ago

ssed

done :)