search

asyncapi / bindings

AsyncAPI bindings specifications
Apache License 2.0
72 stars 75 forks source link

feat: add topicConfiguration property to channel object #171

Closed thake closed 1 year ago

thake commented 2 years ago

resolves #163 by introducing a new topicConfigurationproperty to the channel object.

thake commented 2 years ago

@dalelane, thanks for your fast and very good review :+1: . I've updated the README.md to always point to the kafka documentation for constraints.

thake commented 1 year ago

Is there anything left to do here? Are any more approvals needed? I'm unsure of the proceedings :smirk:

lbroudoux commented 1 year ago

Is there anything left to do here? Are any more approvals needed? I'm unsure of the proceedings 😏

@thake Sorry for the delay and thanks for your PR. I really like your proposition: it adds useful complements!

lbroudoux commented 1 year ago

@dalelane @KhudaDad414 All checks are green. I think we're good for merging! Let me know so that I can proceed.

KhudaDad414 commented 1 year ago

/rtm