asyncapi / bindings

AsyncAPI bindings specifications
Apache License 2.0
72 stars 75 forks source link

MQTT `retain` flag should be applied only to `publish` operations #187

Closed KhudaDad414 closed 11 months ago

KhudaDad414 commented 1 year ago

Reason/Context

The retain flag in MQTT binding should only be applied when the type of operation is publish. It can be applied to publish and subscribe according to the current bindings.

Solution

Remove subscribe from the Applies to column in the operation binding object.

KhudaDad414 commented 1 year ago

/gfi docs

github-actions[bot] commented 1 year ago

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

kushalnl7 commented 1 year ago

Hi, I am interested to do this. Can I try this?

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity :sleeping:

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience :heart:

satyavalli5408 commented 1 year ago

Can i solve this?

AnimeshKumar923 commented 1 year ago

Any update on this? I see a PR (#188 ) opened to fix this issue. ping: @KhudaDad414 @derberg @dalelane @smoya @char0n

char0n commented 1 year ago

@AnimeshKumar923 working on pushing the https://github.com/asyncapi/bindings/pull/188 forward by pinging the PR author.

jonaslagoni commented 11 months ago

Already solved in the v3 compatible bindings 🙂 https://github.com/asyncapi/bindings/tree/master/mqtt#operation-binding-object