asyncapi / bindings

AsyncAPI bindings specifications
Apache License 2.0
72 stars 75 forks source link

feat: add mqtt v5 specific bindings to mqtt #201

Closed pearmaster closed 11 months ago

pearmaster commented 1 year ago

Description According to https://github.com/asyncapi/bindings/issues/199#issuecomment-1567965696 , I'm only adding fields to the mqtt binding. This is because we don't want to create new sets of bindings for each version of each protocol.

Some general changes:

Related issue(s) Fixes #199 by adding new v5 properties to the mqtt binding Fixes #198 by adding maximum packet size

fmvilas commented 1 year ago

@dalelane @derberg @smoya @char0n would love to know your opinion.

smoya commented 1 year ago

LGTM! šŸš€šŸŒ”

Do we want to merge this into master and then adapt it to work with AsyncAPI v3? That already happened in https://github.com/asyncapi/bindings/pull/205, so we will need to update the binding in next-major-spec branch as well. As an alternative, we could do the changes based on next-major-spec and will be released with v3 of the spec, which I think makes sense unless there is a really urgency.

Opinions? cc @jonaslagoni @dalelane @char0n @derberg

derberg commented 1 year ago

we should merge to master, so it is changed for v2 too

jonaslagoni commented 1 year ago

ping ping @pearmaster šŸ™‚

smoya commented 12 months ago

ping ping @pearmaster šŸ™‚

I believe we can proceed with the merge of this PR. Nothing is expected from @pearmaster afaik. Anything else you expect @jonaslagoni ?

jonaslagoni commented 11 months ago

@smoya nothing but the JSON Schema files need to be moved to spec-json-schema repo šŸ™‚

derberg commented 11 months ago

@smoya I just opened https://github.com/asyncapi/spec-json-schemas/pull/464 so I guess we can merge this one and the other PR?

smoya commented 11 months ago

/rtm