Closed pearmaster closed 11 months ago
@dalelane @derberg @smoya @char0n would love to know your opinion.
LGTM! šš
Do we want to merge this into master
and then adapt it to work with AsyncAPI v3? That already happened in https://github.com/asyncapi/bindings/pull/205, so we will need to update the binding in next-major-spec
branch as well.
As an alternative, we could do the changes based on next-major-spec
and will be released with v3 of the spec, which I think makes sense unless there is a really urgency.
Opinions? cc @jonaslagoni @dalelane @char0n @derberg
we should merge to master, so it is changed for v2 too
ping ping @pearmaster š
ping ping @pearmaster š
I believe we can proceed with the merge of this PR. Nothing is expected from @pearmaster afaik. Anything else you expect @jonaslagoni ?
@smoya nothing but the JSON Schema files need to be moved to spec-json-schema repo š
@smoya I just opened https://github.com/asyncapi/spec-json-schemas/pull/464 so I guess we can merge this one and the other PR?
/rtm
Description According to https://github.com/asyncapi/bindings/issues/199#issuecomment-1567965696 , I'm only adding fields to the
mqtt
binding. This is because we don't want to create new sets of bindings for each version of each protocol.Some general changes:
mqtt
binding version to0.2.0
Added a deprecation warning to the
mqtt5
readme to indicate a consolidation of bindings undermqtt
only.Here are specific fields being added:
sessionExpiryInterval
added to the server bindingmaximumPacketSize
added to the server bindingmessageExpiryInterval
added to the operation bindingpayloadFormatIndicator
added to the message bindingcorrelationData
added to the message bindingcontentType
added to the message bindingresponseTopic
added to the message binding.Related issue(s) Fixes #199 by adding new v5 properties to the mqtt binding Fixes #198 by adding maximum packet size